-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build on Solaris where fd-lock cannot be used. #113048
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @ozkanonur (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
Jun 26, 2023
onur-ozkan
requested changes
Jun 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR :)
I haven't tested this. I will try to test it during this week. Adding a reference to the problem/error that this PR fix would be great.
@rustbot author |
rustbot
added
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 26, 2023
psumbera
force-pushed
the
solaris-bootstrap-cfgs
branch
from
June 27, 2023 08:27
1587afa
to
38b60a1
Compare
This comment has been minimized.
This comment has been minimized.
psumbera
force-pushed
the
solaris-bootstrap-cfgs
branch
from
June 27, 2023 08:35
38b60a1
to
e7ba37d
Compare
psumbera
force-pushed
the
solaris-bootstrap-cfgs
branch
from
June 27, 2023 12:29
e7ba37d
to
35cfac1
Compare
onur-ozkan
approved these changes
Jun 28, 2023
@bors r+ rollup |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jun 28, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 29, 2023
Rollup of 5 pull requests Successful merges: - rust-lang#112946 (Improve cgu naming and ordering) - rust-lang#113048 (Fix build on Solaris where fd-lock cannot be used.) - rust-lang#113100 (Fix display of long items in search results) - rust-lang#113107 (add check for ConstKind::Value(_) to in_operand()) - rust-lang#113119 (rustdoc: Reduce internal function visibility.) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes build regression after e7e584b.
Resolves #113085